Hi Lance! Seems like I made a mistake here... When trying to run tests on Windows all tests that use OVSDB_CHECK_MONITOR (ovsdb-monitor.at) raise an error at line 42 where OVS_APP_EXIT_AND_WAIT_BY_TARGET is called. The problem is that ovs-appctl is dumping the target log on stderr and AT_CHECK fails because the output is not expected.
You can see in the previous version (before you added this acros) https://github.com/openvswitch/ovs/blob/6132b241efd21160db57d9908ee630a215cce8ea/tests/ovsdb-monitor.at#L42 that the output is ignored for ovs-appctl call. Besides this all works well. Regards, Paul > -----Original Message----- > From: Lance Richardson [mailto:lrich...@redhat.com] > Sent: Tuesday, June 21, 2016 8:47 PM > To: Paul Boca > Cc: Alin Serdean; dev@openvswitch.org; Ben Pfaff > Subject: Re: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT > > ----- Original Message ----- > > From: "Paul Boca" <pb...@cloudbasesolutions.com> > > To: "Lance Richardson" <lrich...@redhat.com>, "Alin Serdean" > <aserd...@cloudbasesolutions.com> > > Cc: dev@openvswitch.org > > Sent: Tuesday, June 21, 2016 5:37:59 AM > > Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT > > > > Hi Lance! > > > > One small change that should be added to your patch. > > > > diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at > > index ac8749a..5171786 100644 > > --- a/tests/ovs-vsctl.at > > +++ b/tests/ovs-vsctl.at > > @@ -9,7 +9,7 @@ m4_define([OVS_VSCTL_SETUP], > > dnl OVS_VSCTL_CLEANUP > > dnl > > dnl Kills off the database server. > > -m4_define([OVS_VSCTL_CLEANUP], > [OVS_APP_EXIT_AND_WAIT(["`pwd`"/unixctl])]) > > +m4_define([OVS_VSCTL_CLEANUP], > > [OVS_APP_EXIT_AND_WAIT_BY_TARGET(["`pwd`"/unixctl], ["`pwd`"/pid])]) > > > > dnl RUN_OVS_VSCTL(COMMAND, ...) > > dnl > > > > This only affects some Python tests. > > > > Thanks, > > Paul > > Hi Paul, > > That issue, which was introduced after v1 had been posted, was addressed > in v2. > v2 was posted to the ovs-dev list on June 10 (hmm, hopefully v2 isn't getting > too stale...): > > http://openvswitch.org/pipermail/dev/2016-June/072679.html > > Any other issues? > > Thanks, > > Lance _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
