Hi Lance! One small change that should be added to your patch.
diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at index ac8749a..5171786 100644 --- a/tests/ovs-vsctl.at +++ b/tests/ovs-vsctl.at @@ -9,7 +9,7 @@ m4_define([OVS_VSCTL_SETUP], dnl OVS_VSCTL_CLEANUP dnl dnl Kills off the database server. -m4_define([OVS_VSCTL_CLEANUP], [OVS_APP_EXIT_AND_WAIT(["`pwd`"/unixctl])]) +m4_define([OVS_VSCTL_CLEANUP], [OVS_APP_EXIT_AND_WAIT_BY_TARGET(["`pwd`"/unixctl], ["`pwd`"/pid])]) dnl RUN_OVS_VSCTL(COMMAND, ...) dnl This only affects some Python tests. Thanks, Paul > -----Original Message----- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Lance > Richardson > Sent: Tuesday, June 14, 2016 8:56 PM > To: Alin Serdean > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT > > ----- Original Message ----- > > From: "Alin Serdean" <aserd...@cloudbasesolutions.com> > > To: "Lance Richardson" <lrich...@redhat.com>, dev@openvswitch.org > > Sent: Tuesday, June 14, 2016 1:22:36 PM > > Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT > > > > I'll take a look over it tomorrow :). > > > > I saw that you had troubles compiling/linking the project on Windows. > What > > Visual Studio version did you use to compile it? > > > > Thanks, > > Alin. > > > > Hi Alin, > > Thanks, I was going to ping you and paul_boca after the IRC meeting > today about that patch, but missed you both. I'll be traveling > tomorrow, so my responses might be somewhat delayed. > > Initially I tried using 2015, but ran into multiple compilation issues > (the first due to a type collision in pthread.h, easily fixed, I don't > recall what I ran into next), then 2013, which compiled and built with > no issues. However, when I tried to run the tests I saw a series > of "entry point not found" pop-ups. Turns out OVS uses > GetSystemTimePreciseAsFileTime(), which isn't supported on Windows 7 > (it's only available on Windows 8 and 10). Updating to Windows 10 on > the laptop I was using isn't an option (as I found out the hard way) > because the manufacturer hasn't released display drivers for Windows 10. > > Anyway, thanks for asking but I'm unlikely to pursue it any further > (mainly due to a lack of time and lack of the right equipment). > > Regards, > > Lance > > > > -----Mesaj original----- > > > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Lance > > > Richardson > > > Trimis: Friday, June 10, 2016 7:28 PM > > > Către: dev@openvswitch.org > > > Subiect: Re: [ovs-dev] [PATCH] tests: fix issue in use of > > > OVS_APP_EXIT_AND_WAIT > > > > > > ----- Original Message ----- > > > > From: "Lance Richardson" <lrich...@redhat.com> > > > > To: dev@openvswitch.org > > > > Sent: Friday, June 10, 2016 12:17:57 PM > > > > Subject: [ovs-dev] [PATCH] tests: fix issue in use of > > > OVS_APP_EXIT_AND_WAIT > > > > > > > > > > Apologies, I forgot to add the "v2" tag. > > > _______________________________________________ > > > dev mailing list > > > dev@openvswitch.org > > > http://openvswitch.org/mailman/listinfo/dev > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
