On 09/15/2015 01:22 PM, Justin Pettit wrote: > >> On Sep 14, 2015, at 1:27 PM, Russell Bryant <rbry...@redhat.com> wrote: >> >> On 09/14/2015 04:14 PM, ALeX Wang wrote: >>> On 14 September 2015 at 08:33, Ben Pfaff <b...@nicira.com> wrote: >>> >>>> I'm not sure what you mean. The cache that ovs-vsctl implements is only >>>> a cache; that is, leaving it out it doesn't affect correctness. On the >>>> other hand, if there is a cache, then logic is needed to invalidate the >>>> cache if anything changes. >>>> >>>> Maybe you could give an example of the problem you see? >>>> >>>> >>> >>> Sorry, I was confused to believe that cache is compulsory,... it is >>> just used for easy access, using hash. >>> >>> Then, looks good to me~ maybe Russell would also like to look at this? >> >> Thanks for asking, but no need. I think the idea of converting to >> db-ctl-base makes perfect sense. I'm happy if the code looks good to you. >> >> I use it a good bit when testing things, so I'll be sure to report or >> fix anything i run in to. :-) > > Ben, it doesn't look like you've checked this in. Are you still > waiting on an ACK? Alex, did you do a full review?
I read Alex's response as he had done a full review, but I guess there wasn't an ACK. I'm happy to do a full review if it's still needed. -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
