On 09/14/2015 04:14 PM, ALeX Wang wrote: > On 14 September 2015 at 08:33, Ben Pfaff <b...@nicira.com> wrote: > >> On Sun, Sep 13, 2015 at 09:57:58AM -0700, ALeX Wang wrote: >>> On 11 September 2015 at 20:29, Ben Pfaff <b...@nicira.com> wrote: >>> >>>> This makes ovn-nbctl into a pretty slavish imitation of ovn-nbctl, >> using >>>> almost the same code. It has two immediate benefits. First, multiple >>>> commands can now be chained together into a single ovn-nbctl >> invocation. >>>> Second, the database commands such as "create", "set", and so on allow >>>> queries and modifications that don't have specific commands already. >>>> In the following commit, this allows testing the OVN ACL feature. >>>> >>>> Signed-off-by: Ben Pfaff <b...@nicira.com> >> >>> imitation of ovn-sbctl? >> >> Yes, oops >> >>> one thing I noticed is that there is no implementation >>> for 'struct nbctl_context' and 'cache'. so, there is no >>> guarantee that in a long cmd chain, the later cmd >>> will never see the invalid db states. >> >> I'm not sure what you mean. The cache that ovs-vsctl implements is only >> a cache; that is, leaving it out it doesn't affect correctness. On the >> other hand, if there is a cache, then logic is needed to invalidate the >> cache if anything changes. >> >> Maybe you could give an example of the problem you see? >> >> > > Sorry, I was confused to believe that cache is compulsory,... it is > just used for easy access, using hash. > > Then, looks good to me~ maybe Russell would also like to look at this?
Thanks for asking, but no need. I think the idea of converting to db-ctl-base makes perfect sense. I'm happy if the code looks good to you. I use it a good bit when testing things, so I'll be sure to report or fix anything i run in to. :-) -- Russell Bryant _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
