Sat, Aug 23, 2014 at 04:04:50PM CEST, tg...@suug.ch wrote: >On 08/21/14 at 06:19pm, Jiri Pirko wrote: >> This patch introduces the first driver to benefit from the switchdev >> infrastructure and to implement newly introduced switch ndos. This is a >> driver for emulated switch chip implemented in qemu: >> https://github.com/sfeldma/qemu-rocker/ > >The design looks very clean. I noticed that the TLV API is almost an >exact dupliate of the Netlink attributes API. Any specific reason for >not reusing lib/nlattr.c and add what is missing?
Well the api is almost the same. But the implementation is different. See for example rocker_tlv_put. It works directly with desc info. But nla_put works with skb which is not convenient for rocker. Also, struct nlattr is 2xu16 but struct rocker_tlv is u32 u16 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
