On Mon, Oct 21, 2013 at 03:04:25PM -0700, Ben Pfaff wrote: > On Tue, Oct 15, 2013 at 05:17:50PM +0900, Simon Horman wrote: > > Fast failover groups use the actions in > > the first bucket that is alive. > > > > Signed-off-by: Simon Horman <ho...@verge.net.au> > > Please make bucket_is_alive() log a rate-limited warning if it reaches > the liveness depth limit.
Sure, will do. > xlate_ff_group() abandons translation entirely, with ctx->exit, if > there is no live bucket. I think that this reads too much into what > the standard says, which is just "If no buckets are live, packets are > dropped." I think the intention is just that, if there's no live > bucket, don't send the packet to any bucket, but (as usual) the > wording is ambiguous. Yes, I agree. Actually I had come to the same conclusion while reading over the patch at around the same time that you wrote this email. I'll remove setting ctx->exit. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
