Hi,
With these patches in place it is possible to use indirect, all
and fast-failover groups.
This series covers the group features that I am interested in implementing
at this time. In particular it does not include an implementation of the
optional select group. I would be more than happy for someone else to take
on that task.
In order to aid review the series is available in git:
https://github.com/horms/openvswitch.git devel/groups-v7
Key Changes since v6:
* Rebase for re-work of "Add support for write-actions" by Ben Pfaff
Key Changes since v5:
* Add support for translation of fast-failover groups.
* Constify some parameters
Key Changes since v5:
* Add support for translation of fast-failover groups.
* Constify some parameters
Key Changes since v4:
* Rebase
* Add OFPACT_DEC_MPLS_TTL to ofpacts_list_to_action_set()
This was left out of the OFPACT_DEC_MPLS_TTL update made in v4.
Key Changes since v3:
* Rebase
* As suggested by Jarno Rajahalme
- Group instructions in ofpact_is_allowed_in_actions_set()
and add comment about why they are exclude from the actions set.
- Allow OFPACT_DEC_MPLS_TTL in action set.
- Add note about why some non-OpenFlow actions are excluded from
the action set
- Stop translation of actions if looking up the
group of a group actions fails. Previously an attempt
was made to send a packet_in message instead.
- Process action buckets of groups for write list as a list of actions
rather than a set. The action bucket should only be treated as a set if
the group action is part of the action set
* group parameter of group_dpif_get_buckets() should not
be const as the address of one of its fields is assigned
to another parameter.
* Correct cloning logic in xlate_all_group().
It is the flow that should be reset not the base_flow.
Key Changes since v2:
* "ovs-ofctl: Handle any number of buckets in group statistics"
+ As suggested by Ben Pfaff
- Vastly simplify the change by using an explicit pointer for
the 'bucket_stats' member of struct ofputil_group_stats rather
than implicit variable length array appended to the end of the
structure.
* "ofproto-dpif: Implement group callbacks" and
"Translation of indirect and all groups"
+ Rebase for "ofproto-dpif: Hide struct rule_dpif internally"
+ Hide group_dpif in a similar manner to rule_dpif
Patch list and overall diffstat
Simon Horman (3):
ofproto-dpif: Implement group callbacks
Translation of indirect and all groups
Translation of fast failover groups
ofproto/ofproto-dpif-xlate.c | 187 ++++++++++++++++++++++++++++++++++++++++++-
ofproto/ofproto-dpif-xlate.h | 3 +-
ofproto/ofproto-dpif.c | 177 ++++++++++++++++++++++++++++++++++++++--
ofproto/ofproto-dpif.h | 10 +++
ofproto/ofproto.c | 3 +
tests/ofproto-dpif.at | 60 ++++++++++++++
6 files changed, 429 insertions(+), 11 deletions(-)
--
1.8.4
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
