On Tue, Oct 15, 2013 at 05:17:50PM +0900, Simon Horman wrote:
> Fast failover groups use the actions in
> the first bucket that is alive.
> 
> Signed-off-by: Simon Horman <ho...@verge.net.au>

Please make bucket_is_alive() log a rate-limited warning if it reaches
the liveness depth limit.

xlate_ff_group() abandons translation entirely, with ctx->exit, if
there is no live bucket.  I think that this reads too much into what
the standard says, which is just "If no buckets are live, packets are
dropped."  I think the intention is just that, if there's no live
bucket, don't send the packet to any bucket, but (as usual) the
wording is ambiguous.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to