[
https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137302#comment-15137302
]
Christine Poerschke commented on SOLR-8621:
-------------------------------------------
[~shaie], thanks for combining branch snapshot into a patch file.
I've continued work on the solrconfig.xml test changes and from that found that
just a {{<mergeFactor>}} element without a {{<mergePolicy>}} element is
currently valid and {{SolrIndexConfig.java}} needs to consider it, something
like
https://git1-us-west.apache.org/repos/asf?p=lucene-solr.git;a=commit;h=7b21aa1c
- what do you think?
Tomorrow/Tuesday I'm hoping to tackle the tests currently containing
{code}
<mergePolicy
class="${solr.tests.mergePolicy:org.apache.solr.util.RandomMergePolicy}" />
{code}
i.e. continuing on from
http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/28d07935 refactor.
bq. If you prefer that I push it to branch ... But I think it's ready.
Happy for you to take care of the push to master and branch_5x merge.
In terms of ready, if the
[solrconfig-mergepolicy-legacy.xml|https://github.com/apache/lucene-solr/blob/master/solr/core/src/test-files/solr/collection1/conf/solrconfig-mergepolicy-legacy.xml]
i.e. {{TestMergePolicyConfig}} passes and other existing tests pass, then yes
let's go for it and commit the code changes and partial test changes. Once that
is done then we can take care of the remaining tests and examples and the
{{SortingMergePolicy}} for SOLR-5730 can also be added then. How does that
sound?
> solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory>
> -------------------------------------------------------------------------
>
> Key: SOLR-8621
> URL: https://issues.apache.org/jira/browse/SOLR-8621
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Attachments: SOLR-8621.patch
>
>
> *<mergePolicyFactory> end-user benefits:*
> * Lucene's UpgradeIndexMergePolicy can be configured in Solr
> * (with SOLR-5730) Lucene's SortingMergePolicy can be configured in Solr
> * customisability: arbitrary merge policies including wrapping/nested merge
> policies can be created and configured
> *(proposed) roadmap:*
> * solr 5.5 introduces <mergePolicyFactory> support
> * solr 5.5(\?) deprecates (but maintains) <mergePolicy> support
> * solr 6.0(\?) removes <mergePolicy> support
> +work-in-progress git branch:+
> [master-solr-8621|https://github.com/apache/lucene-solr/tree/master-solr-8621]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
