[ 
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983248#comment-14983248
 ] 

Ismael Juma commented on KAFKA-2702:
------------------------------------

For SSL and SASL configs, a default of null can be used for all optional 
configs to fit within the original design of the library.

Personally, I'd prefer if the library supported optional types in a way where 
one could leverage the type system (ie Option and Optional), but that's a 
bigger change and needs to be carefully considered. Relying on each config to 
follow a convention in order to choose the right default for the optional value 
for a given type is error-prone and leads to inconsistencies (-1, null, empty 
list, false, etc.).

> ConfigDef toHtmlTable() sorts in a way that is a bit confusing
> --------------------------------------------------------------
>
>                 Key: KAFKA-2702
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2702
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Gwen Shapira
>            Assignee: Grant Henke
>         Attachments: ConsumerConfig-After.html, ConsumerConfig-Before.html
>
>
> Because we put everything without default first (without prioritizing), 
> critical  parameters get placed below low priority ones when they both have 
> no defaults. Some parameters are without default and optional (SASL server in 
> ConsumerConfig for instance).
> Try printing ConsumerConfig parameters and see the mandatory group.id show up 
> as #15.
> I suggest sorting the no-default parameters by priority as well, or perhaps 
> adding a "REQUIRED" category that gets printed first no matter what.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to