[ https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14979786#comment-14979786 ]
Jay Kreps commented on KAFKA-2702: ---------------------------------- Also note that the check against NO_DEFAULT_VALUE isn't a check against the empty string it is a check against being the object named NO_DEFAULT_VALUE (i.e. reference equality vs object equality). That object happens to be an empty string so it prints out as nothing but that doesn't make it equal to other empty strings for the purpose of determining if there is a default or not. > ConfigDef toHtmlTable() sorts in a way that is a bit confusing > -------------------------------------------------------------- > > Key: KAFKA-2702 > URL: https://issues.apache.org/jira/browse/KAFKA-2702 > Project: Kafka > Issue Type: Bug > Reporter: Gwen Shapira > Assignee: Grant Henke > Attachments: ConsumerConfig-After.html, ConsumerConfig-Before.html > > > Because we put everything without default first (without prioritizing), > critical parameters get placed below low priority ones when they both have > no defaults. Some parameters are without default and optional (SASL server in > ConsumerConfig for instance). > Try printing ConsumerConfig parameters and see the mandatory group.id show up > as #15. > I suggest sorting the no-default parameters by priority as well, or perhaps > adding a "REQUIRED" category that gets printed first no matter what. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
