[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982636#comment-14982636
]
Grant Henke commented on KAFKA-2702:
------------------------------------
[~gwenshap] Yeah, there is definitely some config cleanup needed. This is for
similar reason to what [~jkreps] was saying:
{quote}
Originally the presence or absence of a default indicated whether something was
required
{quote}
Before doing that I want to be sure we agree on the approach. Should we:
A. Keep the required field, adjust the sort, and cleanup configs.
B. Remove the required field, and cleanup configs adding defaults where needed.
> ConfigDef toHtmlTable() sorts in a way that is a bit confusing
> --------------------------------------------------------------
>
> Key: KAFKA-2702
> URL: https://issues.apache.org/jira/browse/KAFKA-2702
> Project: Kafka
> Issue Type: Bug
> Reporter: Gwen Shapira
> Assignee: Grant Henke
> Attachments: ConsumerConfig-After.html, ConsumerConfig-Before.html
>
>
> Because we put everything without default first (without prioritizing),
> critical parameters get placed below low priority ones when they both have
> no defaults. Some parameters are without default and optional (SASL server in
> ConsumerConfig for instance).
> Try printing ConsumerConfig parameters and see the mandatory group.id show up
> as #15.
> I suggest sorting the no-default parameters by priority as well, or perhaps
> adding a "REQUIRED" category that gets printed first no matter what.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
