Hi PoAn, Thanks for the KIP. I have a few comments. AS1: It seems to me that these new additions are most useful to people trying to understand the progress of rebalancing in quite some detail. The information is really not understandable for most users who do not have deep knowledge of KIP-848/932.
As a result, I suggest for kafka-share-groups.sh that you add a --members --verbose option and only include the new information in the output for that option, rather than changing the non-verbose --members output. I also make a similar suggestion for kafka-consumer-groups.sh --members and only add the new information for the --verbose output. AS2: I strongly suggest that you use MEMBER-EPOCH instead of CONSUMER-EPOCH. I think it's more confusing not following the terminology of the KIPs. For one thing, we already have "member" in the admin client such as MemberDescription. It's not a new term. Thanks, Andrew ________________________________________ From: PoAn Yang <pay...@apache.org> Sent: 25 October 2024 13:55 To: dev@kafka.apache.org <dev@kafka.apache.org> Subject: Re: [DISCUSS] KIP-1099: Extend kafka-consumer-groups command line tool to support new consumer group Hi Lucas, Thanks for the review! 1) Yes, I add related change for kafka-share-groups.sh to the KIP. Could you take a look? Thanks for the suggestion. 2) We use CONSUMER-ID as member ID. If we use MEMBER-EPOCH here, users may confuse what is different between CONSUMER and MEMBER. Thanks, PoAn On 2024/10/23 13:28:17 Lucas Brutschy wrote: > Hi Frank, > > thanks for the KIP! > > 1) For consistency, should we do the same for > kafka-share-groups.sh, ShareGroupDescription, etc. ? Even if we do not > implement it right now if the share group implementation may still be > incomplete, it may make sense to include it in the KIP. > > 2) Why call it CONSUMER-EPOCH, not MEMBER-EPOCH? That would seem more > consistent. > > Cheers, > Lucas > > On Wed, Oct 23, 2024 at 2:41 PM Frank Yang <yangp...@gmail.com> wrote: > > > Hi all, > > > > I would like to kick off the discussion of KIP-1099. This KIP enhances the > > kafka-consumer-groups tools to include state which is introduced by KIP-848. > > > > KIP-1099: Extend kafka-consumer-groups command line tool to support new > > consumer group - Apache Kafka - Apache Software Foundation > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1099%3A+Extend+kafka-consumer-groups+command+line+tool+to+support+new+consumer+group> > > cwiki.apache.org > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1099%3A+Extend+kafka-consumer-groups+command+line+tool+to+support+new+consumer+group> > > [image: favicon.ico] > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1099%3A+Extend+kafka-consumer-groups+command+line+tool+to+support+new+consumer+group> > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1099%3A+Extend+kafka-consumer-groups+command+line+tool+to+support+new+consumer+group> > > > > Thank you, > > PoAn > > >
