Hi Lucas, Thanks for the review!
1) Yes, I add related change for kafka-share-groups.sh to the KIP. Could you take a look? Thanks for the suggestion. 2) We use CONSUMER-ID as member ID. If we use MEMBER-EPOCH here, users may confuse what is different between CONSUMER and MEMBER. Thanks, PoAn On 2024/10/23 13:28:17 Lucas Brutschy wrote: > Hi Frank, > > thanks for the KIP! > > 1) For consistency, should we do the same for > kafka-share-groups.sh, ShareGroupDescription, etc. ? Even if we do not > implement it right now if the share group implementation may still be > incomplete, it may make sense to include it in the KIP. > > 2) Why call it CONSUMER-EPOCH, not MEMBER-EPOCH? That would seem more > consistent. > > Cheers, > Lucas > > On Wed, Oct 23, 2024 at 2:41 PM Frank Yang <yangp...@gmail.com> wrote: > > > Hi all, > > > > I would like to kick off the discussion of KIP-1099. This KIP enhances the > > kafka-consumer-groups tools to include state which is introduced by KIP-848. > > > > KIP-1099: Extend kafka-consumer-groups command line tool to support new > > consumer group - Apache Kafka - Apache Software Foundation > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1099%3A+Extend+kafka-consumer-groups+command+line+tool+to+support+new+consumer+group> > > cwiki.apache.org > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1099%3A+Extend+kafka-consumer-groups+command+line+tool+to+support+new+consumer+group> > > [image: favicon.ico] > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1099%3A+Extend+kafka-consumer-groups+command+line+tool+to+support+new+consumer+group> > > <https://cwiki.apache.org/confluence/display/KAFKA/KIP-1099%3A+Extend+kafka-consumer-groups+command+line+tool+to+support+new+consumer+group> > > > > Thank you, > > PoAn > > >
