> On April 3, 2014, 1:13 a.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/api/TopicMetadata.scala, line 35
> > <https://reviews.apache.org/r/19957/diff/1/?file=546093#file546093line35>
> >
> > Nitpick, but I think this would be a little neater:
> > (0 to numPartitions).map( <loop body> ).toArray
>
> Timothy Chen wrote:
> (0 to numPartitions).map(null).toArray actually gives me a null pointer
> exception :)
Oh - I didn't mean map(null). I meant map { <loop body you currently have
}.toArray
- Joel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19957/#review39378
-----------------------------------------------------------
On April 3, 2014, 1:39 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19957/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 1:39 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1356
> https://issues.apache.org/jira/browse/KAFKA-1356
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1356 Improve topic metadata handling in kafka api
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/api/TopicMetadata.scala
> 0513a59ed94e556894b3515dc38666ee9a66ae3d
> core/src/main/scala/kafka/controller/KafkaController.scala
> fcabd0da201ccd478f5884bcca9b75a8c8ea8373
> core/src/main/scala/kafka/server/KafkaApis.scala
> c068ef69207c351eec413a595f1747c59f8b3983
>
> Diff: https://reviews.apache.org/r/19957/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Timothy Chen
>
>
