----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39378 -----------------------------------------------------------
core/src/main/scala/kafka/api/TopicMetadata.scala <https://reviews.apache.org/r/19957/#comment71779> Nitpick, but I think this would be a little neater: (0 to numPartitions).map( <loop body> ).toArray core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/19957/#comment71771> You can just call aliveBrokers.get(leader) core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/19957/#comment71773> I think this really should have been isr.map(aliveBrokers.get).filter(_.isEmpty) - Joel Koshy On April 2, 2014, 8:44 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19957/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 8:44 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1356 > https://issues.apache.org/jira/browse/KAFKA-1356 > > > Repository: kafka > > > Description > ------- > > KAFKA-1356 Improve topic metadata handling in kafka api > > > Diffs > ----- > > core/src/main/scala/kafka/api/TopicMetadata.scala > 0513a59ed94e556894b3515dc38666ee9a66ae3d > core/src/main/scala/kafka/server/KafkaApis.scala > c068ef69207c351eec413a595f1747c59f8b3983 > > Diff: https://reviews.apache.org/r/19957/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
