+1 (non-binding)
Thanks for running the release!

Verified signature, checksum, and license check. Built and tested using JDK
17 (`17.0.6-zulu`)


I also tried building with Java 21 (`21.0.4-amzn`) but ran into the
following failed tests. I don't think this is blocking the current RC since
support for building with Java 21 was added recently to v1.7.0
<https://iceberg.apache.org/releases/#170-release> (issue #10474
<https://github.com/apache/iceberg/pull/10474>)
```
> Task :iceberg-kafka-connect:iceberg-kafka-connect-runtime:integrationTest

IntegrationDynamicTableTest > initializationError FAILED
    org.testcontainers.containers.ContainerLaunchException at
GenericContainer.java:351
        Caused by: org.rnorth.ducttape.RetryCountExceededException at
Unreliables.java:88
            Caused by:
org.testcontainers.containers.ContainerLaunchException at
GenericContainer.java:555
                Caused by: java.lang.IllegalStateException at
GenericContainer.java:487

IntegrationMultiTableTest > initializationError FAILED
    org.testcontainers.containers.ContainerLaunchException at
GenericContainer.java:351
        Caused by: org.rnorth.ducttape.RetryCountExceededException at
Unreliables.java:88
            Caused by:
org.testcontainers.containers.ContainerLaunchException at
GenericContainer.java:555
                Caused by: java.lang.IllegalStateException at
GenericContainer.java:487

IntegrationTest > initializationError FAILED
    org.testcontainers.containers.ContainerLaunchException at
GenericContainer.java:351
        Caused by: org.rnorth.ducttape.RetryCountExceededException at
Unreliables.java:88
            Caused by:
org.testcontainers.containers.ContainerLaunchException at
GenericContainer.java:555
                Caused by: java.lang.IllegalStateException at
GenericContainer.java:487

3 tests completed, 3 failed

> Task :iceberg-kafka-connect:iceberg-kafka-connect-runtime:integrationTest
FAILED
```

The test report shows that all 3 tests failed on the `initializationError`
step with
```
org.testcontainers.containers.ContainerLaunchException: Container startup
failed for image docker:24.0.2
```

and I double-checked that `docker` is indeed running on my laptop.


Best,
Kevin Liu

On Tue, Dec 3, 2024 at 7:31 AM Jean-Baptiste Onofré <j...@nanthrax.net> wrote:

> +1 (non binding)
>
> Regards
> JB
>
> On Thu, Nov 21, 2024 at 2:35 PM Bryan Keller <brya...@gmail.com> wrote:
> >
> > Hi Everyone,
> >
> > I propose that we release the following RC as the official Apache
> Iceberg 1.7.1 release.
> >
> > The commit ID is 4a432839233f2343a9eae8255532f911f06358ef
> > * This corresponds to the tag: apache-iceberg-1.7.1-rc1
> > * https://github.com/apache/iceberg/commits/apache-iceberg-1.7.1-rc1
> > *
> https://github.com/apache/iceberg/tree/4a432839233f2343a9eae8255532f911f06358ef
> >
> > The release tarball, signature, and checksums are here:
> > *
> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.7.1-rc1
> >
> > You can find the KEYS file here:
> > * https://dist.apache.org/repos/dist/dev/iceberg/KEYS
> >
> > Convenience binary artifacts are staged on Nexus. The Maven repository
> URL is:
> > *
> https://repository.apache.org/content/repositories/orgapacheiceberg-1178
> >
> > Please download, verify, and test.
> >
> > Please vote in the next 72 hours.
> >
> > [ ] +1 Release this as Apache Iceberg 1.7.1
> > [ ] +0
> > [ ] -1 Do not release this because...
> >
> > Only PMC members have binding votes, but other community members are
> encouraged to cast
> > non-binding votes. This vote will pass if there are 3 binding +1 votes
> and more binding
> > +1 votes than -1 votes.
> >
> > (NOTE: The vote on 1.7.1 RC0 was skipped as a last minute bug fix came
> in.)
> >
>

Reply via email to