rdblue commented on a change in pull request #14: Pluggable file I/O submodule
in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r240437553
##########
File path: core/src/main/java/com/netflix/iceberg/TableOperations.java
##########
@@ -56,27 +55,17 @@
void commit(TableMetadata base, TableMetadata metadata);
/**
- * Create a new {@link InputFile} for a path.
- *
- * @param path a string file path
- * @return an InputFile instance for the path
+ * @return a {@link com.netflix.iceberg.FileIO} to read and write table data
and metadata files
*/
- InputFile newInputFile(String path);
+ FileIO io();
/**
- * Create a new {@link OutputFile} in the table's metadata store.
- *
- * @param filename a string file name, not a full path
- * @return an OutputFile instance for the path
- */
- OutputFile newMetadataFile(String filename);
-
- /**
- * Delete a file.
- *
- * @param path path to the file
+ * Given the name of a metadata file, return the full path that points to
that data file.
Review comment:
I think it is slightly different. Given a filename, create a full path using
an appropriate location for metadata files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
