rdblue commented on a change in pull request #14: Pluggable file I/O submodule
in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r240416052
##########
File path:
core/src/main/java/com/netflix/iceberg/hadoop/HadoopTableOperations.java
##########
@@ -91,7 +91,7 @@ public TableMetadata refresh() {
}
this.version = ver;
this.currentMetadata = TableMetadataParser.read(this,
- HadoopInputFile.fromPath(metadataFile, conf));
+ fileIo().newInputFile(metadataFile.toString()));
Review comment:
`Path#toUri` is actually not a good thing to use because it has escaping
problems in some cases. The right thing to do is to use strings and paths.
Isn't it possible for `HadoopTableOperations` to update the signature to use
`HadoopFileIO`? I thought you could always be more specific, but maybe that's
just that you can tell Java when the object is more specific, but not require
it of subclasses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
