rdblue commented on a change in pull request #14: Pluggable file I/O submodule
in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r240421070
##########
File path:
core/src/main/java/com/netflix/iceberg/hadoop/HadoopTableOperations.java
##########
@@ -91,7 +91,7 @@ public TableMetadata refresh() {
}
this.version = ver;
this.currentMetadata = TableMetadataParser.read(this,
- HadoopInputFile.fromPath(metadataFile, conf));
+ fileIo().newInputFile(metadataFile.toString()));
Review comment:
I don't think it would be unreasonable for `HadoopTableOperations` to
require a `HadoopFileIO`, but I don't think it is a big deal to call `toString`
here, either. Up to you which you prefer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
