ok2c commented on code in PR #555:
URL:
https://github.com/apache/httpcomponents-client/pull/555#discussion_r1556181108
##########
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManagerBuilder.java:
##########
@@ -273,15 +275,24 @@ public final PoolingHttpClientConnectionManagerBuilder
useSystemProperties() {
return this;
}
+ @Internal
+ protected HttpClientConnectionOperator createConnectionOperator(
+ final SchemePortResolver schemePortResolver,
+ final DnsResolver dnsResolver,
+ final TlsSocketStrategy tlsSocketStrategy,
+ final boolean systemProperties) {
+ return new DefaultHttpClientConnectionOperator(schemePortResolver,
dnsResolver,
+ RegistryBuilder.<TlsSocketStrategy>create()
+ .register(URIScheme.HTTPS.id, tlsSocketStrategy !=
null ? tlsSocketStrategy :
Review Comment:
@tippl `systemProperties` condition does not belong here. Please make this
method consistent with that of `PoolingAsyncClientConnectionManagerBuilder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
