ok2c commented on PR #555: URL: https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2004622070
> Is there a reason for not being able to add the `HttpClientConnectionOperator` to the builder? > @tippl The are two reasons: 1. Internal interfaces ideally should leak into the public APIs. There is a few instances where it was necessary but I am reluctant to create more 2. `HttpClientConnectionOperator` would be mutually exclusive with several attributes of the builder: `SchemePortResolver`, `DnsResolver` and `TlsSocketStrategy`. That is just bad. > Especially since the only reason for extending in this case would be to access a protected constructor. If this is a feature the library provides, an user shouldn't use workarounds to use it at all. That is exactly the thing. This feature may be very important for your application but, dare I say, for majority of users it is completely irrelevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
