tippl commented on PR #555: URL: https://github.com/apache/httpcomponents-client/pull/555#issuecomment-2041466636
@ok2c Sorry for the delay. Hopefully this is more to your liking. I've tried to avoid the need of having to extend the `PoolingHttpClientConnectionManager` to use a custom Operator, so i made the constructor public as per what you suggested in the mail communication, however i've kept the Internal annotation to signify it shouldn't be used during regular use. (to still push people towards the builder) I've also modified the bulilders to allow extending, this way even if you want to use the callbacks, you don't have to fully manually configure the `PoolingHttpClientConnectionManager`, allowing you to extend the builder and override just the build method to use the custom Operator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
