[ https://issues.apache.org/jira/browse/HTTPCLIENT-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792528#comment-17792528 ]
Daniel Krämer commented on HTTPCLIENT-2292: ------------------------------------------- [~ggregory] There still seems to be an issue / regression that was not fixed with 5.2.3. See [https://github.com/jenkinsci/docker-plugin/issues/1032] I'm currently trying to reproduce this, but some help would be greatly appreciated. > SOCKS proxy configuration is not working > ---------------------------------------- > > Key: HTTPCLIENT-2292 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2292 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpClient (classic) > Affects Versions: 5.2.2 > Reporter: Václav Kužel > Priority: Minor > Fix For: 5.2.3, 5.3-alpha2 > > Time Spent: 50m > Remaining Estimate: 0h > > h3. Current behaviour > A SOCKS proxy can be configured via the > {{PoolingHttpClientConnectionManagerBuilder. setDefaultSocketConfig()}} > method which accepts {{SocketConfig.setSocksProxyAddress(socksaddr)}} > configuration. > **The {{socksProxyAddress}} configuration is ignored in class HttpClient** > h3. Expected behaviour > * Proxy aware socket instances are instantiated by the {{Socket(Proxy > proxy)}} constructor. > * Sockets are created via the {{ConnectionSocketFactory.createSocket()}} > method. > * The {{DefaultHttpClientConnectionOperator.connect()}} method, which holds > aforementioned configuration, calls the socket factory. > So, we need to pass the proxy address from the operator into the socket > factory method. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org