[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765528#comment-17765528
 ] 

ASF subversion and git services commented on HTTPCLIENT-2292:
-------------------------------------------------------------

Commit 404a3ab83e569f4fcdb24337bcd1b52f57992a8f in httpcomponents-client's 
branch refs/heads/5.2.x from Oleg Kalnichevski
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=404a3ab83 ]

HTTPCLIENT-2292: HttpClient ignores socketConfig#getSocksProxyAddress


> SOCKS proxy configuration is not working
> ----------------------------------------
>
>                 Key: HTTPCLIENT-2292
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2292
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (classic)
>    Affects Versions: 5.2.1
>            Reporter: Václav Kužel
>            Priority: Minor
>
> h3. Current behaviour
> A SOCKS proxy can be configured via the 
> {{PoolingHttpClientConnectionManagerBuilder. setDefaultSocketConfig()}} 
> method which accepts {{SocketConfig.setSocksProxyAddress(socksaddr)}} 
> configuration.
> **The {{socksProxyAddress}} configuration is ignored in class HttpClient**
> h3. Expected behaviour
> * Proxy aware socket instances are instantiated by the {{Socket(Proxy 
> proxy)}} constructor.
> * Sockets are created via the {{ConnectionSocketFactory.createSocket()}} 
> method.
> * The {{DefaultHttpClientConnectionOperator.connect()}} method, which holds 
> aforementioned configuration, calls the socket factory.
> So, we need to pass the proxy address from the operator into the socket 
> factory method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to