[
https://issues.apache.org/jira/browse/HTTPCLIENT-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760991#comment-17760991
]
Oleg Kalnichevski commented on HTTPCLIENT-2292:
-----------------------------------------------
[~vkuzel] Please review / test the proposed fix:
[https://github.com/apache/httpcomponents-client/commit/aa5a7c7fe043935164729d2c92d00860f8c7afc8]
Oleg
> SOCKS proxy configuration is not working
> ----------------------------------------
>
> Key: HTTPCLIENT-2292
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2292
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpClient (classic)
> Affects Versions: 5.2.1
> Reporter: Václav Kužel
> Priority: Minor
>
> h3. Current behaviour
> A SOCKS proxy can be configured via the
> {{PoolingHttpClientConnectionManagerBuilder. setDefaultSocketConfig()}}
> method which accepts {{SocketConfig.setSocksProxyAddress(socksaddr)}}
> configuration.
> **The {{socksProxyAddress}} configuration is ignored in class HttpClient**
> h3. Expected behaviour
> * Proxy aware socket instances are instantiated by the {{Socket(Proxy
> proxy)}} constructor.
> * Sockets are created via the {{ConnectionSocketFactory.createSocket()}}
> method.
> * The {{DefaultHttpClientConnectionOperator.connect()}} method, which holds
> aforementioned configuration, calls the socket factory.
> So, we need to pass the proxy address from the operator into the socket
> factory method.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
