Sure that is fine with me you are the release manager ;-) I don't want to say let's not include anything else, just saying that we need a cutoff point, as we have been postponing this for a while...
On Fri, Sep 11, 2015 at 2:51 PM, Fabian Hueske <fhue...@gmail.com> wrote: > We're waiting for a fix of FLINK-2637 (TypeInfo equals + hashcode). > Once this is in, we do the first release candidate, OK? > > 2015-09-11 14:48 GMT+02:00 Stephan Ewen <se...@apache.org>: > > > Fixes come up on a daily base. I think at some point we need to declare > > freeze, or this thing will never be released. > > > > @Fabian: Since you are release manager, do you want to pick the point to > > declare freeze (and pick what should be included)? > > > > On Fri, Sep 11, 2015 at 2:41 PM, Matthias J. Sax <mj...@apache.org> > wrote: > > > > > I would have an important fix too. > > > > > > https://issues.apache.org/jira/browse/FLINK-2658 > > > https://github.com/apache/flink/pull/1122 > > > > > > Or is it too late? > > > > > > > > > On 09/10/2015 06:54 PM, Robert Metzger wrote: > > > > Since the vote has not been started yet, we might consider including > > this > > > > critical fix for the Kafka consumer into 0.10-milestone1: > > > > https://github.com/apache/flink/pull/1117 > > > > > > > > On Thu, Sep 10, 2015 at 1:54 PM, Matthias J. Sax <mj...@apache.org> > > > wrote: > > > > > > > >> I justed opened a PR for FLINK-2632: "Web Client does not respect > the > > > >> class loader of submitted jobs" > > > >> > > > >> https://github.com/apache/flink/pull/1114 > > > >> > > > >> -Matthias > > > >> > > > >> > > > >> On 09/10/2015 11:49 AM, Fabian Hueske wrote: > > > >>> All these bugs reported by users and its just four of them of > which 2 > > > are > > > >>> already fixed. > > > >>> It should be possible to fix them in a day. > > > >>> > > > >>> 2015-09-10 11:19 GMT+02:00 Robert Metzger <rmetz...@apache.org>: > > > >>> > > > >>>> Thank you very much for taking care of the release management! > > > >>>> > > > >>>> I'm not sure whether it makes sense to block a "preview" release > on > > so > > > >> many > > > >>>> bug fixes. It feels like 80% of our commits are bugfixes or > > stability > > > >>>> improvements anyways, so we would wait infinitely to release the > > > >> milestone > > > >>>> if we wait for all of them. > > > >>>> > > > >>>> For example for the class loader issue in the web client issue, > Max > > > (who > > > >>>> initially brought the issue to our attention) also said: "Would be > > > nice > > > >> to > > > >>>> fix it but IMHO it is not critical for the milestone release." > > > >>>> > > > >>>> > > > >>>> I would vote for merging Till's > > > >> https://github.com/apache/flink/pull/1101 > > > >>>> and then start with the RC0 vote. > > > >>>> If there are more bug fixes available and the RC0 vote fails > (which > > is > > > >>>> likely ;) ), we can include them as well. > > > >>>> > > > >>>> > > > >>>> > > > >>>> On Thu, Sep 10, 2015 at 11:04 AM, Fabian Hueske < > fhue...@gmail.com> > > > >> wrote: > > > >>>> > > > >>>>> I can take the role of the release manager and push the 0.10 > > > milestone > > > >>>>> release forward. > > > >>>>> > > > >>>>> I added a list of pending fixes for 0.10 to the wiki: > > > >>>>> https://cwiki.apache.org/confluence/display/FLINK/0.10+Release > > > >>>>> Please extend the list (or respond to this thread) if you have > more > > > >> fixes > > > >>>>> that should go into the release. > > > >>>>> > > > >>>>> From the currently open issues only FLINK-2632 (Web Client does > not > > > >>>> respect > > > >>>>> the class loader of submitted jobs) is unassigned. > > > >>>>> Anybody around to pick this one up? > > > >>>>> > > > >>>>> Cheers, Fabian > > > >>>>> > > > >>>>> 2015-09-09 12:00 GMT+02:00 Till Rohrmann <trohrm...@apache.org>: > > > >>>>> > > > >>>>>> I forgot to mention that there is also a bug with the > `StreamFold` > > > >>>>> operator > > > >>>>>> which we might consider fixing for the milestone release. I've > > > opened > > > >> a > > > >>>>> PR > > > >>>>>> for it. > > > >>>>>> > > > >>>>>> https://issues.apache.org/jira/browse/FLINK-2631 > > > >>>>>> https://github.com/apache/flink/pull/1101 > > > >>>>>> > > > >>>>>> > > > >>>>>> On Wed, Sep 9, 2015 at 10:58 AM, Gyula Fóra <gyf...@apache.org> > > > >> wrote: > > > >>>>>> > > > >>>>>>> This sounds good +1 from me as well :) > > > >>>>>>> Till Rohrmann <till.rohrm...@gmail.com> ezt írta (időpont: > 2015. > > > >>>>> szept. > > > >>>>>>> 9., > > > >>>>>>> Sze, 10:40): > > > >>>>>>> > > > >>>>>>>> +1 for a milestone release with the TypeInformation issues > > fixed. > > > >>>> I'm > > > >>>>>>>> working on it. > > > >>>>>>>> > > > >>>>>>>> On Tue, Sep 8, 2015 at 9:32 PM, Stephan Ewen < > se...@apache.org> > > > >>>>> wrote: > > > >>>>>>>> > > > >>>>>>>>> Great! > > > >>>>>>>>> > > > >>>>>>>>> I'd like to push one more commit later today. > > > >>>>>>>>> A fix for https://issues.apache.org/jira/browse/FLINK-2632 > > would > > > >>>>>> also > > > >>>>>>> be > > > >>>>>>>>> highly appreciated by some users. > > > >>>>>>>>> > > > >>>>>>>>> Anyone volunteering as release manager (for creating release > > > >>>>>> candidates > > > >>>>>>>> and > > > >>>>>>>>> uploading them)? > > > >>>>>>>>> > > > >>>>>>>>> > > > >>>>>>>>> On Tue, Sep 8, 2015 at 6:11 PM, Kostas Tzoumas < > > > >>>>> ktzou...@apache.org> > > > >>>>>>>>> wrote: > > > >>>>>>>>> > > > >>>>>>>>>> +1 for a milestone release > > > >>>>>>>>>> > > > >>>>>>>>>> On Tue, Sep 8, 2015 at 5:43 PM, Robert Metzger < > > > >>>>>> rmetz...@apache.org> > > > >>>>>>>>>> wrote: > > > >>>>>>>>>> > > > >>>>>>>>>>> +1 for a "milestone1" release. We have a lot of good > features > > > >>>>> in > > > >>>>>>>> master > > > >>>>>>>>>>> that people can benefit from. > > > >>>>>>>>>>> > > > >>>>>>>>>>> On Tue, Sep 8, 2015 at 5:10 PM, Maximilian Michels < > > > >>>>>> m...@apache.org > > > >>>>>>>> > > > >>>>>>>>>> wrote: > > > >>>>>>>>>>> > > > >>>>>>>>>>>> +1 for releasing a milestone release soon to encourage > > > >>>> people > > > >>>>>> to > > > >>>>>>>> try > > > >>>>>>>>>>>> out the new features. > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> There is this bug: > > > >>>>>>>> https://issues.apache.org/jira/browse/FLINK-2632 > > > >>>>>>>>>>>> which affects the Web Client's error and results display > > > >>>> for > > > >>>>>>> jobs. > > > >>>>>>>>>>>> Would be nice to fix it but IMHO it is not critical for > the > > > >>>>>>>> milestone > > > >>>>>>>>>>>> release. > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> On Tue, Sep 8, 2015 at 1:00 PM, Ufuk Celebi < > > > >>>> u...@apache.org> > > > >>>>>>>> wrote: > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>>> On 08 Sep 2015, at 12:01, Stephan Ewen < > > > >>>> se...@apache.org> > > > >>>>>>>> wrote: > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> Hi all! > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> Some day back we talked about releasing an > > > >>>>> 0.10.0-milestone1 > > > >>>>>>>>>> release. > > > >>>>>>>>>>>> The > > > >>>>>>>>>>>>>> master has advanced quite a bit (especially due to > > > >>>>>>>>> high-availability > > > >>>>>>>>>>>> code). > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> I cherry picked the important additions to the > > > >>>>>>>>>>> release-0.10.0-milestone1 > > > >>>>>>>>>>>>>> branch (fixes and Kafka consumer/producer rework). > > > >>>>>>>>>>>>>> > > > >>>>>>>>>>>>>> How about releasing the branch now as an intermediate > > > >>>>>> version > > > >>>>>>>> for > > > >>>>>>>>>>>> people to > > > >>>>>>>>>>>>>> try out while we stabilize the windows and HA code for > > > >>>> the > > > >>>>>>> 0.10 > > > >>>>>>>>>>> release? > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> +1 > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> Thanks for cping the important changes. I’ve checked and > > > >>>>>> there > > > >>>>>>> is > > > >>>>>>>>>>>> nothing I would add at this point. > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> Can anybody else took a look at it? Other than that, I > > > >>>>> think > > > >>>>>>> it’s > > > >>>>>>>>>> good > > > >>>>>>>>>>>> to go. > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>>> – Ufuk > > > >>>>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>> > > > >>>>>>>>>> > > > >>>>>>>>> > > > >>>>>>>> > > > >>>>>>> > > > >>>>>> > > > >>>>> > > > >>>> > > > >>> > > > >> > > > >> > > > > > > > > > > > > >