On 3/15/14 9:44 PM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>Hi, > >> I happened to notice that SWFObject was in the repo, and potentially had >> an Apache header added to it. >Will check. Was already in there not anything I changed. Yeah, I didn't see you add it, but by luck I just happened to notice there is at least one copy in there. That means work for the build script as it will have to download SWFObject and copy it into all of those places. > >>> A couple of minor issues - but noting I can see to stop making a >>>release. >>> - After compiling rat_report shows 5 incompatible licences. >> Why wouldn't that be a show stopper? > >Because they are in files that are in the 3rd party downloads. Are these for optional features? Required features cannot depend on incompatible licenses, and we have to make sure the build and install scripts offer the option like we do for the fontswf jars. -Alex
