I'm not going to debate on the basis of a 6k difference, honestly. 6k is not a 'hit'. 6k takes not even half a second to download... on a 128kb modem! On an average broadband connection (I don't believe I'm actually taking the time to type this) it takes around 1/100th of a second.
What we get for this is a really clean framework (no IE8Utils, FlexGlobals etc.). We don't have to spend time on fixes for the 'roll-your-own' solution. We have a fully enterprise tested and real-world proofed event system that does not depend on DOM elements. It maps well to the Flex event system users and developers are used to. Please take a look at the code, I spend some time with the framework itself and cleaned it up a bit as well. EdB On Wed, Apr 24, 2013 at 9:08 PM, Alex Harui <aha...@adobe.com> wrote: > I'm just starting to look at the diffs. But please, no variables named > "assing" :-) > > So do you really believe it will take more than 6K of minified code to fix > any bugs related to events in the current implementation? > > I'm wondering if the motivation behind goog.events is to get an event system > to work across a lot of older browsers we don't care about these days like > IE6 and IE7. If that's the case, why take on all of that code? > > I know when Adobe wrote the JS layer for BrowserManager it had a lot of code > paths we can probably drop if we don't have to support older browsers. > > I wouldn't want to take a 6K hit unless we really understand what we're > getting for it. > > > On 4/24/13 11:45 AM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: > >> In short (I have the branch updated and ready to be published: yes to all >> three: >> >> 1) it adds about 6k to the file (26k -> 32k) >> 2) yes, without modification, so no more IE8Utils or whatever >> 3) yes >> >> But I'll still publish a branch first, so you can see for yourself >> (there are some other changes/fixes in there as well). >> >> EdB >> >> >> >> On Wed, Apr 24, 2013 at 8:39 PM, Alex Harui <aha...@adobe.com> wrote: >>> I think I don't have any more commits planned on for flex-asjs unless there >>> is a bug fix or two. I'm planning to work on a COMPC equivalent for >>> FalconJX. >>> >>> My only criteria for your proposed switch to goog.events are: >>> 1) is the minified js for the example as small as what we have now? >>> 2) does it work on IE8? >>> 3) when writing AS code, do we still get to use dispatchEvent(new Event())? >>> >>> If the answer to all 3 is yes, then I don't have a problem moving over to >>> goog.events. Otherwise, I would say the status quo is the better choice. >>> >>> >>> On 4/24/13 11:21 AM, "Erik de Bruin" <e...@ixsoftware.nl> wrote: >>> >>>> BTW: the re-write/refactoring was somewhat major, so I plan to publish >>>> my branch first, so we can review and discuss. It will still be nice >>>> to have it on par with the 'develop' branch initially, though. >>>> >>>> EdB >>>> >>>> >>>> >>>> On Wed, Apr 24, 2013 at 8:10 PM, Erik de Bruin <e...@ixsoftware.nl> wrote: >>>>> Alex, >>>>> >>>>> I see you're doing some committing. I have the 'goog.events' based >>>>> framework done for a previous version of FlexJS and I'm not waiting to >>>>> update it to the latest and greatest. >>>>> >>>>> Do you have any more commits planned for 'today'? >>>>> >>>>> EdB >>>>> >>>>> >>>>> >>>>> -- >>>>> Ix Multimedia Software >>>>> >>>>> Jan Luykenstraat 27 >>>>> 3521 VB Utrecht >>>>> >>>>> T. 06-51952295 >>>>> I. www.ixsoftware.nl >>>> >>>> >>> >>> -- >>> Alex Harui >>> Flex SDK Team >>> Adobe Systems, Inc. >>> http://blogs.adobe.com/aharui >>> >> >> > > -- > Alex Harui > Flex SDK Team > Adobe Systems, Inc. > http://blogs.adobe.com/aharui > -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
