> -----Original Message-----
> From: Jeff Daly <je...@silicom-usa.com>
> Sent: Wednesday, April 13, 2022 01:42
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Stephen Douthit <steph...@silicom-usa.com>; Wang, Haiyue
> <haiyue.w...@intel.com>
> Subject: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug
>
> Currently the ixgbe driver does not ID any SFP except for the first one
> plugged in. This can lead to no-link, or incorrect speed conditions.
>
> For example:
>
> * If link is initially established with a 1G SFP, and later a 1G/10G
> multispeed part is later installed, then the MAC link setup functions are
> never called to change from 1000BASE-X to 10GBASE-R mode, and the link
> stays running at the slower rate.
>
> * If link is initially established with a 1G SFP, and later a 10G only
> module is later installed, no link is established, since we are still
> trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner.
>
> Refactor the SFP ID/setup, and link setup code, to more closely match the
> flow of the mainline kernel driver which does not have these issues. In
> that driver a service task runs periodically to handle these operations
> based on bit flags that have been set (usually via interrupt or userspace
> request), and then get cleared once the requested subtask has been
> completed.
>
> Fixes: af75078fece ("first public release")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Stephen Douthit <steph...@silicom-usa.com>
> Signed-off-by: Jeff Daly <je...@silicom-usa.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 533 +++++++++++++++++++++++--------
> drivers/net/ixgbe/ixgbe_ethdev.h | 14 +-
> 2 files changed, 410 insertions(+), 137 deletions(-)
>
>
> struct ixgbe_stat_mapping_registers {
> @@ -510,7 +509,7 @@ struct ixgbe_adapter {
> uint8_t pflink_fullchk;
> uint8_t mac_ctrl_frame_fwd;
> rte_atomic32_t link_thread_running;
> - pthread_t link_thread_tid;
> + pthread_t service_thread_tid;
No need to rename this variable, we can separate this patch as least into
two patches:
1st, change the thread handle 'ixgbe_dev_setup_link_thread_handler' from
run-once to as periodical, to handle the original issue.
The name 'ixgbe_dev_setup_link_thread_handler' may be not suitable now,
as it is a service thread.
We can change it to "'ixgbe_link_service_thread_handler'" to reflect the
change purpose.
2nd, add the SFP hotplug in this patch.
> };
>
> --
> 2.25.1
