On Thu, Oct 21, 2021 at 3:04 PM Chengwen Feng <fengcheng...@huawei.com> wrote:
>
> This patch add check for rte_dma_info_get() API.
Fixes: 718f7804841f ("test/dma: add basic dmadev instance tests")
>
> Signed-off-by: Chengwen Feng <fengcheng...@huawei.com>
Thanks for following up.
> ---
> app/test/test_dmadev.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
> index 8b58256afc..d6d5dfc803 100644
> --- a/app/test/test_dmadev.c
> +++ b/app/test/test_dmadev.c
> @@ -746,8 +746,11 @@ test_dmadev_instance(int16_t dev_id)
> .nb_desc = TEST_RINGSIZE,
> };
> const int vchan = 0;
> + int ret;
>
> - rte_dma_info_get(dev_id, &info);
> + ret = rte_dma_info_get(dev_id, &info);
> + if (ret)
Nit: ret != 0
> + ERR_RETURN("Error with rte_dma_info_get()\n");
>
> printf("\n### Test dmadev instance %u [%s]\n",
> dev_id, info.dev_name);
> @@ -761,8 +764,8 @@ test_dmadev_instance(int16_t dev_id)
> if (rte_dma_vchan_setup(dev_id, vchan, &qconf) < 0)
> ERR_RETURN("Error with queue configuration\n");
>
> - rte_dma_info_get(dev_id, &info);
> - if (info.nb_vchans != 1)
> + ret = rte_dma_info_get(dev_id, &info);
> + if (ret || info.nb_vchans != 1)
Nit: ret != 0
> ERR_RETURN("Error, no configured queues reported on device id
> %u\n", dev_id);
>
> if (rte_dma_start(dev_id) != 0)
> --
> 2.33.0
>
Reviewed-by: David Marchand <david.march...@redhat.com>
--
David Marchand
