Function create_ipsec_esp_flow returns a negative number in case of any
failure and we are passing this to strerror to dsiplay the error message.
But strerror()'s argument cannot be negative.
In case of failure, displaying exact error message to console is handled
in create_ipsec_esp_flow function.So it is not required to print the
error message again using strerror.
This patch will remove the unnecessary calling of strerror function
to fix the negative argument passing to strerror issue.
Coverity issue: 357691
Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director")
Cc: praveen.she...@intel.com
Signed-off-by: Praveen Shetty <praveen.she...@intel.com>
Acked-by: Lukasz Wojciechowski <l.wojciec...@partner.samsung.com>
---
v2 changes:
changed commit headline and rephrased commit message.
examples/ipsec-secgw/sa.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c
index e3a1a5aff..632482176 100644
--- a/examples/ipsec-secgw/sa.c
+++ b/examples/ipsec-secgw/sa.c
@@ -1223,8 +1223,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa
entries[],
rc = create_ipsec_esp_flow(sa);
if (rc != 0)
RTE_LOG(ERR, IPSEC_ESP,
- "create_ipsec_esp_flow() failed %s\n",
- strerror(rc));
+ "create_ipsec_esp_flow() failed\n");
}
print_one_sa_rule(sa, inbound);
}
--
2.17.1
