On Thu, 16 May 2019 13:46:58 +0200
Jakub Grajciar <jgraj...@cisco.com> wrote:

> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index f0061d99f..b05f1462d 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2493,6 +2493,8 @@ pmd_test_exit(void)
>                       device = rte_eth_devices[pt_id].device;
>                       if (device && !strcmp(device->driver->name, 
> "net_virtio_user"))
>                               detach_port_device(pt_id);
> +                     else if (device && !strcmp(device->driver->name, 
> "net_memif"))
> +                             detach_port_device(pt_id);
>               }
>       }


Why not do a proper implementation of dev_close instead of pushing
the problem onto the application.

The existing virtio_user hack is a bug and it should be fixed.
  • [dpdk-dev] [... Jakub Grajciar
    • [dpdk-d... Jakub Grajciar
      • [dp... Jakub Grajciar
        • ... Stephen Hemminger
        • ... Stephen Hemminger
        • ... Stephen Hemminger
          • ... Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
        • ... Stephen Hemminger
        • ... Stephen Hemminger
        • ... Jakub Grajciar
          • ... Ferruh Yigit
            • ... Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
          • ... Jakub Grajciar
            • ... Ye Xiaolong
              • ... Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
                • ... Ye Xiaolong
              • ... Ferruh Yigit
            • ... Aaron Conole
            • ... Ferruh Yigit

Reply via email to