> -----Original Message-----
> From: Varghese, Vipin

> +/**< Enable port debug. */
In comment , Enable displaying port info?

> +static uint32_t enable_dbg_port;
Do you want to consider replacing "debug" to "show" in code here other places? 
As you have already changed the commands to "show."

                                ring_name = optarg;
How about doing memcpy instead of pointer assignment? Similarly below. Though I 
don't see issue here. But safe to use memcpy.

> +                     } else if (!strncmp(long_option[option_index].name,
> +                                     "dbg-mempool",
> MAX_LONG_OPT_SZ)) {
> +                             enable_dbg_mempool = 1;
> +                             mempool_name = optarg;
> +                     }

Thanks,
Reshma

Reply via email to