-----Original Message----- > Date: Wed, 3 Oct 2018 10:41:33 +0300 > From: Andrew Rybchenko <arybche...@solarflare.com> > To: Jerin Jacob <jerin.ja...@caviumnetworks.com>, Wenzhuo Lu > <wenzhuo...@intel.com>, Jingjing Wu <jingjing...@intel.com>, Bernard > Iremonger <bernard.iremon...@intel.com>, John McNamara > <john.mcnam...@intel.com>, Marko Kovacevic <marko.kovace...@intel.com>, > Thomas Monjalon <tho...@monjalon.net>, Ferruh Yigit > <ferruh.yi...@intel.com>, Olivier Matz <olivier.m...@6wind.com> > CC: dev@dpdk.org, shah...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP > checksum definition > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 > Thunderbird/60.0 > > External Email > > On 10/2/18 10:24 PM, Jerin Jacob wrote: > > Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags and > PKT_TX_OUTER_TCP_CKSUM mbuf ol_flags to enable Tx outer UDP > checksum offload. > > PKT_TX_OUTER_UDP_CKSUM, not TCP
OK > > > > > To use hardware Tx outer UDP checksum offload, the user needs to, > > - enable following in mbuff: > > > mbuf OK > > > a) fill outer_l2_len and outer_l3_len in mbuf > b) set the PKT_TX_OUTER_UDP_CKSUM flag > c) set the flag PKT_TX_OUTER_IPV4 or PKT_TX_OUTER_IPV6 > > - configure DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slow path > > Signed-off-by: Jerin Jacob > <jerin.ja...@caviumnetworks.com><mailto:jerin.ja...@caviumnetworks.com> > > The question about mbuf and ethdev changes separation is applicable here as > well. I have no strong opinion, but I think it would be good to follow. I don't have strong opinion on this. If there are no other objection, I will split the patch further as mbuf and ethdev as you pointed out.
