-----Original Message----- > Date: Mon, 1 Oct 2018 14:46:39 +0100 > From: Ferruh Yigit <ferruh.yi...@intel.com> > To: Jerin Jacob <jerin.ja...@caviumnetworks.com>, Wenzhuo Lu > <wenzhuo...@intel.com>, Jingjing Wu <jingjing...@intel.com>, Bernard > Iremonger <bernard.iremon...@intel.com>, John McNamara > <john.mcnam...@intel.com>, Marko Kovacevic <marko.kovace...@intel.com>, > Thomas Monjalon <tho...@monjalon.net>, Andrew Rybchenko > <arybche...@solarflare.com> > CC: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload > support > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > > On 9/13/2018 2:47 PM, Jerin Jacob wrote: > > Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > Overall set looks good to me, I put some comments on individual patches. > > And can you please rebase on top of latest head?
Sure. Regarding space issue mentioned in other email in this thread. It looks like similar space added in other offloads. example: http://git.dpdk.org/dpdk/tree/app/test-pmd/config.c#n571 So, I expect no change in this patch other than rebase to latest head. If not, let me know. > > Thanks, > ferruh >
