Hi Thomas See my answers inlined.
> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, October 27, 2014 10:24 PM > To: Zhang, Helin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 7/8] ethdev: support of multiple sizes of > redirection table > > 2014-10-22 19:53, Helin Zhang: > > +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t)) > > How can it be different of 64? > Using 64 would be simpler to understand than RTE_BIT_WIDTH_64. > > > + uint8_t reta[RTE_BIT_WIDTH_64]; /**< 64 redirection table entries. */ We always try to use macro in code to replace numeric, this can get the numeric more understandable. > > Even your comment is saying that it's 64. > > -- > Thomas Regards, Helin
