2014-10-27 13:21, Matthew Hall: > On Mon, Oct 27, 2014 at 03:13:39PM +0100, Thomas Monjalon wrote: > > You didn't answer to my previous comment on this. > > I think these definitions are useless. 64 is 64. > > Putting labels on the constants gives meaning to them as well as a numeric > value. Not doing so is an antipattern referred to as "magic numbers" > antipattern.
Are you kidding Matthew? I'm referring to these constants: > +#define ETH_RSS_RETA_SIZE_64 64 > +#define ETH_RSS_RETA_SIZE_128 128 > +#define ETH_RSS_RETA_SIZE_512 512 It's not RETA_SIZE which would have a meaning but RETA_SIZE_64. We could also define RETA_SIZE_32 or RETA_SIZE_33... > A maintainence programmer or community member will have a difficult time > figuring out lost context when grepping through the code. > > Matthew.
