kangpinghuang commented on a change in pull request #909: Fix wrong version set
in TabletMeta and rowset null pointer
URL: https://github.com/apache/incubator-doris/pull/909#discussion_r274735113
##########
File path: be/src/olap/task/engine_storage_migration_task.cpp
##########
@@ -127,8 +127,8 @@ OLAPStatus
EngineStorageMigrationTask::_storage_medium_migrate(
}
// generate new header file from the old
- TabletMeta* new_tablet_meta = new(std::nothrow) TabletMeta();
- if (new_tablet_meta == NULL) {
+ TabletMetaSharedPtr new_tablet_meta(new(std::nothrow) TabletMeta());
+ if (new_tablet_meta == nullptr) {
OLAP_LOG_WARNING("new olap header failed");
Review comment:
LOG(WARNING)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
