kangpinghuang commented on a change in pull request #909: Fix wrong version set 
in TabletMeta and rowset null pointer
URL: https://github.com/apache/incubator-doris/pull/909#discussion_r274734303
 
 

 ##########
 File path: be/src/olap/snapshot_manager.cpp
 ##########
 @@ -279,7 +279,7 @@ string SnapshotManager::_get_header_full_path(
 
 void SnapshotManager::update_header_file_info(
         const vector<RowsetSharedPtr>& consistent_rowsets,
-        TabletMeta* tablet_meta) {
 
 Review comment:
   why change pointer to shared_ptr?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to