kangpinghuang commented on a change in pull request #909: Fix wrong version set 
in TabletMeta and rowset null pointer
URL: https://github.com/apache/incubator-doris/pull/909#discussion_r274734875
 
 

 ##########
 File path: be/src/olap/tablet_manager.cpp
 ##########
 @@ -686,16 +686,15 @@ TabletSharedPtr 
TabletManager::find_best_tablet_to_compaction(CompactionType com
 
 OLAPStatus TabletManager::load_tablet_from_meta(DataDir* data_dir, TTabletId 
tablet_id,
         TSchemaHash schema_hash, const std::string& meta_binary) {
-    std::unique_ptr<TabletMeta> tablet_meta(new TabletMeta());
+    TabletMetaSharedPtr tablet_meta(new TabletMeta());
 
 Review comment:
   TabletMetaSharedPtr tablet_meta(new(std::nothrow) TabletMeta());

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to