kangpinghuang commented on a change in pull request #909: Fix wrong version set
in TabletMeta and rowset null pointer
URL: https://github.com/apache/incubator-doris/pull/909#discussion_r274734911
##########
File path: be/src/olap/tablet_meta.cpp
##########
@@ -54,11 +54,11 @@ OLAPStatus TabletMeta::create(int64_t table_id, int64_t
partition_id,
uint64_t shard_id, const TTabletSchema&
tablet_schema,
uint32_t next_unique_id,
const std::unordered_map<uint32_t, uint32_t>&
col_ordinal_to_unique_id,
- TabletMeta** tablet_meta) {
- *tablet_meta = new TabletMeta(table_id, partition_id,
- tablet_id, schema_hash,
- shard_id, tablet_schema,
- next_unique_id, col_ordinal_to_unique_id);
+ TabletMetaSharedPtr* tablet_meta) {
+ tablet_meta->reset(new TabletMeta(table_id, partition_id,
Review comment:
std::nothrow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
