kangpinghuang commented on a change in pull request #516: Modify compaction
code to be adapted to Rowset interface
URL: https://github.com/apache/incubator-doris/pull/516#discussion_r246647352
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -1523,22 +1523,21 @@ OLAPStatus SchemaChangeHandler::_do_alter_tablet(
}
// acquire data sources correspond to history versions
- ref_tablet->acquire_data_sources_by_versions(
- versions_to_be_changed, &olap_data_arr);
- if (olap_data_arr.size() < 1) {
+ ref_tablet->capture_rs_readers(versions_to_be_changed, &rs_readers);
+ if (rs_readers.size() < 1) {
OLAP_LOG_WARNING("fail to acquire all data sources."
"[version_num=%d data_source_num=%d]",
versions_to_be_changed.size(),
- olap_data_arr.size());
+ rs_readers.size());
Review comment:
change OLAP_LOG_WARNING -> LOG(WARNING)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
