kangpinghuang commented on a change in pull request #516: Modify compaction
code to be adapted to Rowset interface
URL: https://github.com/apache/incubator-doris/pull/516#discussion_r246645995
##########
File path: be/src/olap/base_compaction.h
##########
@@ -82,35 +84,35 @@ class BaseCompaction {
//
// 输入参数：
// - new_base_version_hash: 新Base的VersionHash
- // - base_data_sources: 生成新Base需要的ColumnData*
+ // - rs_readers : 生成新Base需要的RowsetReaders*
// - row_count: 生成Base过程中产生的row_count
//
// 返回值：
// - 如果执行成功，则返回OLAP_SUCCESS；
// - 其它情况下，返回相应的错误码
OLAPStatus _do_base_compaction(VersionHash new_base_version_hash,
- std::vector<ColumnData*>* base_data_sources,
- uint64_t* row_count);
+ const std::vector<RowsetSharedPtr>& rowsets,
+ uint64_t* row_count);
Review comment:
wrong indent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
