kangpinghuang commented on a change in pull request #516: Modify compaction code to be adapted to Rowset interface URL: https://github.com/apache/incubator-doris/pull/516#discussion_r246373102
########## File path: be/src/olap/cumulative_compaction.h ########## @@ -110,13 +112,13 @@ class CumulativeCompaction { // 返回值: // - 如果成功,返回OLAP_SUCCESS // - 如果不成功,返回相应错误码 - OLAPStatus _update_header(std::vector<SegmentGroup*>* unused_indices); + OLAPStatus _update_header(std::vector<RowsetSharedPtr>* unused_indices); Review comment: change the unused_indices name ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org