kangpinghuang commented on a change in pull request #516: Modify compaction
code to be adapted to Rowset interface
URL: https://github.com/apache/incubator-doris/pull/516#discussion_r246373759
##########
File path: be/src/olap/rowset/rowset.h
##########
@@ -58,6 +58,12 @@ class Rowset {
virtual bool zero_num_rows() const = 0;
virtual size_t num_rows() const = 0;
+
+ virtual Version version() const;
Review comment:
should use virtual Version version const = 0;
change the following.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
