2014-03-16 17:06 GMT+01:00 Matt Benson <gudnabr...@gmail.com>: > On Mar 16, 2014 7:03 AM, "Benedikt Ritter" <brit...@apache.org> wrote: > > > > Hello Matt, > > > > The artifacts look good to me. I agree with Gary that the documentation > > could be improved. The main page of all module should provide some more > > information. ON > > > > http://commons.apache.org/proper/commons-weaver/commons-weaver-maven-plugin/plugin-info.htmlthe > > example still contains 1.0-SNAPSHOT as version. > > > > The example is generated; the actual rc3 site linked in the initial VOTE > email looks right to me. > > > Signs and hashes look good. > > archives have the same content as the tag > > > > However I'm having problems building weaver. > > When I extract the src.tar.gz and call mvn install in the top directory I > > get: > > [ERROR] The projects in the reactor contain a cyclic reference: Edge > > between > 'Vertex{label='org.apache.commons:commons-weaver-build-tools:1.0'}' > > and 'Vertex{label='org.apache.commons:commons-weaver-parent:1.0'}' > > introduces to cycle in the graph > > org.apache.commons:commons-weaver-parent:1.0 --> > > org.apache.commons:commons-weaver-build-tools:1.0 --> > > org.apache.commons:commons-weaver-parent:1.0 -> [Help 1] > > > > When I try to install the modules I get: > > [ERROR] Failed to execute goal on project commons-weaver-modules-parent: > > Could not resolve dependencies for project > > org.apache.commons:commons-weaver-modules-parent:pom:1.0: Could not find > > artifact org.apache.commons:commons-weaver-maven-plugin:jar:1.0 in > central ( > > http://repo.maven.apache.org/maven2) -> [Help 1] > > > > When I try to install the maven plugin I get: > > [ERROR] Failed to execute goal on project commons-weaver-maven-plugin: > > Could not resolve dependencies for project > > org.apache.commons:commons-weaver-maven-plugin:maven-plugin:1.0: Could > not > > find artifact org.apache.commons:commons-weaver-processor:jar:1.0 in > > central (http://repo.maven.apache.org/maven2) -> [Help 1] > > > > When I try to install the processor I get: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce > > (enforce-maven-3) on project commons-weaver-processor: Some Enforcer > rules > > have failed. Look above for specific messages explaining why the rule > > failed. -> [Help 1] > > > > What do I have to do to build the project? > > > > I suspect from your [lang] 3.2.1 thread that you're using Maven 3.2.x. Try > using Maven 3.1.x instead, and calling 'install' or 'package' in the root. > I added this to the enforcer setup, but it may not be working properly. As > discussed in the rc1 thread, the plan is to remove the recursion post 1.0. > The recursion issue and Maven version limitation are discussed at > http://people.apache.org/~mbenson/commons-weaver-1.0-rc3/building.html. > > Build from sources works with maven 3.1.1.
+1 > Thanks for your attention, > Matt > > > Benedikt > > > > > > 2014-03-12 0:33 GMT+01:00 Matt Benson <mben...@apache.org>: > > > > > Apache Commons Weaver 1.0 RC3 is available for review at: > > > https://dist.apache.org/repos/dist/dev/commons/weaver/ (r4624). > > > > > > Maven artifacts are at: > > > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1018/ > > > . > > > > > > Tested with Oracle JDKs 6, 7 and 8. > > > > > > The Subversion tag is: > > > http://svn.apache.org/repos/asf/commons/proper/weaver/tags/1.0_RC3/ > > > (r1576397). > > > > > > Site: > > > http://people.apache.org/~mbenson/commons-weaver-1.0-rc3/index.html > > > > > > RAT Report: > > > > http://people.apache.org/~mbenson/commons-weaver-1.0-rc3/rat-report.html > > > > > > Keys: https://dist.apache.org/repos/dist/release/commons/KEYS > > > > > > Changes since RC2: > > > - Configured project to run a single all-inclusive RAT report > > > - Added missing license headers > > > - Included issueManagement in POM (and thus in generated site) > > > - Documented resulting need for expanded permgen when generating site > > > > > > Changes since RC1: > > > - Removed -dist suffix from distribution files > > > - Added release notes to binary distribution > > > - Included project-specific LICENSE.txt and NOTICE.txt in jar > artifacts > > > - Restricted checkstyle to run only for relevant modules > > > - Fixed remaining checkstyle errors > > > - Improved (somewhat) overview documentation > > > - Removed license header from release notes > > > - Added FindBugs and PMD reporting > > > > > > Please review the release candidate and vote. > > > This vote will close no sooner that 72 hours from now, i.e. after > 0000UTC > > > 15-March 2014 > > > > > > [ ] +1 Release these artifacts > > > [ ] +0 OK, but... > > > [ ] -0 OK, but really should fix... > > > [ ] -1 I oppose this release because... > > > > > > Thanks! > > > > > > > > > > > -- > > http://people.apache.org/~britter/ > > http://www.systemoutprintln.de/ > > http://twitter.com/BenediktRitter > > http://github.com/britter > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
