Yonik Seeley wrote: > Not sure I understand the use of "forked" here. > > Solr needed CSV handing. Rather than just roll our own, I looked at > commons-csv and put a *lot* of time and effort into improving it. I > didn't have time to follow through with a complete release of > commons-csv, so we just included a snapsot in Solr. It's an internal > implementation detail, and hopefully you'll all agree that commons-csv > has benefited. There have been *no* custom additions or anything else > - it's just a snapshot.
You spoil the classpath for anyone else using commons-csv. This has nothing to do with Maven. Just by renaming the jar file you gained *nothing*. Would you've been pleased if we publish jar files that contain classes in package org.apache.solr.* ??? All that we can do now is to put a big red warning at commons-cvs homepage: ========== %< ========== CAUTION: If you use Apache Solr you run implicitly an incompatible version of commons-csv that may affect your application. We have to refuse any help for problems if you run also Apache Solr - we are sorry! ========== %< ========== > Of course with the whole maven thing it almost makes it almost look > like a release. I'm not a maven guy (and I don't particularly care > for it). If there's something wrong with the maven config, hopefully > you can explain that to the Lucene/Solr maven guys. To me, it's > simply an implementation detail within solr and definitely shouldn't > be advertised as any kind of official release on it's own. And yet you expose your classes as the "real thing" to the world! Don't you think there's a reason why the JDK contains apache code in com.sun.internal.org.apache.*? With the renaming of the artifact in Maven you have simply additionally hidden the problem! > ps: I'm away for the week in Korea w/ limited internet access, so I'll > most likely be unable to respond personally to any followups. ... and leaving the user's of commons-csv and Solr in the rain. Thanks! Jörg, Apache Commons PMC --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
