sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support
for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#discussion_r124878483
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
##########
@@ -509,9 +509,12 @@ public static BookieSocketAddress
getBookieAddress(ServerConfiguration conf)
iface = "default";
}
InetSocketAddress inetAddr = new
InetSocketAddress(DNS.getDefaultHost(iface), conf.getBookiePort());
- String hostAddress = inetAddr.getAddress().getHostAddress();
- if (conf.getUseHostNameAsBookieID()) {
- hostAddress = inetAddr.getAddress().getCanonicalHostName();
+ String hostAddress = "127.0.0.1";
Review comment:
Any insights of this change? If the inetAddr isUnresolved, shall we just
fail the bookie, because:
- if it is a fresh bookie, the address '127.0.0.1' that it announces is
wrong.
- if it is a bookie already registered, the address will be different from
the ip in the cookie.
I am not sure why do we need this change here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
