sijie commented on a change in pull request #183: BOOKKEEPER-588 SSL Support
for Bookkeeper
URL: https://github.com/apache/bookkeeper/pull/183#discussion_r129728455
##########
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -1323,14 +1341,14 @@ private OperationType getOperationType(byte opCode) {
private void readV3Response(final Response response) {
final BKPacketHeader header = response.getHeader();
- final CompletionValue completionValue =
completionObjects.remove(newCompletionKey(header.getTxnId(),
+ final CompletionValue completionValue =
completionObjects.get(newCompletionKey(header.getTxnId(),
Review comment:
any reason why change remove to get?
if seems a new completion key is created for each get and remove, at least
if we can use same key that would reduce garbages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
